Xsd2Code Work Item Rss Feed

Commented Issue: Generation from XSD wich contains only types declarations doesn't work [6941]

tadamson — Tue, 21 May 2013 05:58:33 GMT

1. Create XSD files wich contains only complextype and simpletype declarations (without any elements declarations).
2. Run Xsd2Code
Result: File with empty namespace generated
Comments: ** Comment from web user: tadamson **

changeset 54081 only seems to generate for complextype declarations but not simpletype. In my case I needed it for enumerations:

Xsd2Code.Library/Generator.cs:132:
```
foreach (XmlSchemaComplexType complex in xsd.Items.OfType<XmlSchemaComplexType>())
{
var mapping = importer.ImportSchemaType(complex.QualifiedName);
exporter.ExportTypeMapping(mapping);
}
```

This modification seems to work?:
```
foreach (XmlSchemaType type in xsd.Items.OfType<XmlSchemaType>())
{
var mapping = importer.ImportSchemaType(type.QualifiedName);
exporter.ExportTypeMapping(mapping);
}
```

Closed Issue: Element are automatically added when using type of collection 'List' [6709]

pcabanel — Thu, 16 May 2013 12:13:41 GMT

I have noticed that when I serialize and then immediately deserialize, optional elements that were not present in the input, may be added to the output. This only happens when I generate the class using tpe of collection 'List', not when I use 'Array'. For me, this is undesirable behaviour.
Here is an example that illustrates the behaviour:
Input:
<?xml version="1.0" encoding="utf-8"?>
<test />
Output Array:
<?xml version="1.0"?>
<test xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" />
Output List:
<?xml version="1.0"?>
<test xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<optionalInt>
<value>0</value>
</optionalInt>
<optionalString />
</test>
OptionalInt has a minoccurs of 0, value has a minoccurs of 1.

I think it has something to do with the fact that there are required elements below optional elements.

I used the following invocation of xsd2code:
xsd2code.exe ".\TestOptionalElement.xsd" TestOptional "TestOptionalElement.cs" CS List noDataBinding HidePrivateInIde

See attachment for a complete package to reproduce the behaviour:
1. Schema
2. Image of the schema
3. Sample project (.Net 2005)
4. Command file to generate the class

Closed Issue: Problems with inherited schema types in referenced files [6938]

pcabanel — Thu, 16 May 2013 12:13:41 GMT

Condition: We have ab.xsd file which contains two complex types A and B where B inherited from A and this file referenced by file which contains element of type A.
Problem: Generated class A doesn't have XmlIncludeAttribute for type B.

I fixed this problem locally and will try to send patch.

Closed Issue: Setup does not place addin file correctly if My Documents folder is moved [6988]

pcabanel — Thu, 16 May 2013 12:13:40 GMT

Hi,

Thanks for the cool tool!

I changed the location of My Documents using the right click "move" option.
However, the setup still placed the addin file in the old location which made the addin not appear in VS.
Changing the file location fixed the problem.

Closed Issue: make XmlSerializer static in base class [7914]

pcabanel — Thu, 16 May 2013 12:13:38 GMT

- Make XmlSerializer static:

public partial class EntityBase<T> {
static readonly XmlSerializer Serializer = new XmlSerializer(typeof(T));
Then whenever you need to serialize/deserialize, just use that static serializer

Closed Issue: Stackoverflow in constructor (circular class reference) [8018]

reokubo — Thu, 16 May 2013 12:13:37 GMT

With this schema, Xsd2Code generates a circular reference in constructor.

<?xml version="1.0" encoding="utf-8" ?>

<xs:schema xmlns:mstns="http://tempuri.org/CircularClassReference.xsd" elementFormDefault="qualified" targetNamespace="http://tempuri.org/CircularClassReference.xsd" id="CircularClassReference" xmlns:xs="http://www.w3.org/2001/XMLSchema">
<xs:complexType name="Circular">
<xs:sequence>
<xs:element name="circular" type="mstns:Circular" />
</xs:sequence>
</xs:complexType>
<xs:element name="Root" type="mstns:Circular" />
</xs:schema>

Code :

public partial class Circular : EntityBase<Circular>
{

private Circular circularField;

public Circular()
{
if ((this.circularField == null))
{
this.circularField = new Circular();
}
}

public Circular circular
{
get
{
return this.circularField;
}
set
{
this.circularField = value;
}
}
}

Closed Issue: Propertyname are wrongly set to non existing members in ctor when using auto properties and List collections [8094]

pcabanel — Thu, 16 May 2013 12:13:37 GMT

When generating targeting net35 and setting auto props true and using List as collections the generator creates constructur code that mistakenly nullchecks and tries to init a non existing myAutoPropertyNameMember member. Should nullcheck (is this necissary?) and init the autoproperty with public name, i.e. MyAutoPropertyName.

Closed Issue: Instantiation of optional elements [8118]

pcabanel — Thu, 16 May 2013 12:13:37 GMT

For optional items, an element is incorrectly instantiated in the constructor of the created code.

For example:

<xsd:complexType name="requestType">
<xsd:annotation>
<xsd:documentation>Configure the parameters for the search query</xsd:documentation>
</xsd:annotation>
<xsd:sequence>
<xsd:element name="Context" type="typs:ContextType" minOccurs="0"/>
<xsd:element name="SearchConfig" type="SearchConfigType"/>
<xsd:element name="SearchParams" type="SearchParamsType"/>
</xsd:sequence>
</xsd:complexType>

Creates:

public requestType() {
if ((this.searchParamsField == null)) {
this.searchParamsField = new SearchParamsType();
}
if ((this.searchConfigField == null)) {
this.searchConfigField = new SearchConfigType();
}
if ((this.contextField == null)) {
this.contextField = new ContextType();
}
}

For the contextField, this instantiation should not exist.

I've tried checking the source code, but could not find an easy way to disable this. Alternatively, I've build a version that does not instantiate members at all.

Closed Issue: List combined with Automatic Properties is failing [8943]

boomhauer — Thu, 16 May 2013 12:13:36 GMT

Appears that in place of what should be List<myType>{get;set;},
I am seeing instead: List'1{get;set;}
and the original "private" vars are not removed- ie, private List<myType>; still exists and was not removed. (tho the private vars do have the right types, and dont use the weird List'1 form)

Closed Issue: Need switch: All Automatic properties [9025]

pcabanel — Thu, 16 May 2013 12:13:36 GMT

Following the issues, i have a feature request: No initialisation in constructor or Get parameters.

For example, when i have this class (simplified):

public class Root
{
public List<Child> Children;
}

And I receive this xml:

<root/>

I will have a problem detecting if any empty collection was passed, or if the collection was passed at all (and that is something completely different).

Also, when creating object structures, I don't want objects to be instantiated automatically (on get accessors), because that would generate the same randomness.

So please: Automatic properties for all.

Closed Issue: Xsd2Code Generates Error filled Visual Basic Code. [9029]

pcabanel — Thu, 16 May 2013 12:13:36 GMT

Xsd2Code Generates Error filled Visual Basic Code. Diagnosed that it uses C#/CPP CodeSnippetExpressions. Specifically, CodeDomHelper.GetDispose ( != null vs IsNot Nothing).
CodeExtension.CreateInstanceCodeStatement properly handles equality test in CodeDom Neutral Way.
Lots of Other CodeSnippetExpressionsare C#/CPP Specific.

Steps to Reproduce - Create VisualBasic ClassLibrary generate with all options on. Look at errors.

Closed Issue: incorrect doc text for GenerateCloneMethod [10042]

pcabanel — Thu, 16 May 2013 12:13:36 GMT

In the CustomTool, dialog, the help text at the bottom of the window for GenerateCloneMethod appears to be wrong -- looks like it was cut/pasted from IncludeSerializeMethod.

And while you're in there, the text for IncludeSerializeMethod has a typo: "nust" -> "must"

Closed Issue: XmlElementAttribute is generated with a missing comma. [11335]

pcabanel — Thu, 16 May 2013 12:13:35 GMT

The generated code looks like this:
[System.Xml.Serialization.XmlElementAttribute("container"typeof(T_OptionContainer))]

It is missing a comma between the "container" and typeof(T_OptionContainer))]
This gives me an exception:
Invalid token 'typeof' in class, struct, or interface member declaration

Closed Issue: vs2010 menu item missing [11548]

Snympi — Thu, 16 May 2013 12:13:35 GMT

the right click menu item for compiling xsd files is missing in my vs2010 installation

Windows 7 64 bit

visual studio 2010 ultimate

xsd2code 3.3 beta 2 for vs2010

Closed Issue: xml annotations error [11558]

boomhauer — Thu, 16 May 2013 12:13:34 GMT

my output generated this, which doesnt compile
[System.Xml.Serialization.XmlElementAttribute("doubleValues"typeof(double))]
[System.Xml.Serialization.XmlElementAttribute("stringValues"typeof(string))]
public object Item {get; set;}

i bleieve it should be:
[System.Xml.Serialization.XmlElementAttribute("doubleValues", typeof(double))]
[System.Xml.Serialization.XmlElementAttribute("stringValues", typeof(string))]
public object Item {get; set;}

Closed Issue: incorrect auto properties [11562]

pcabanel — Thu, 16 May 2013 12:13:34 GMT

I have some xsd's which Ive told to generate auto properties, which it does for most of the strings. but there are a few strings which still get gnereated with "normal" property style, but they lack the internal variable definiteioin. so they fail to compile. these seems to show up when xml annotation is also turned on.

Closed Issue: SerializableAttribute error in silverlight. [11761]

pcabanel — Thu, 16 May 2013 12:13:33 GMT

Silverilght version also has SerializableAttribute - it's an error.

Closed Issue: The GenericBaseClass/BaseClassName field is lost every time you close the dialog. [13557]

pcabanel — Thu, 16 May 2013 12:13:31 GMT

The GenericBaseClass/BaseClassName field is lost every time you close the dialog.

Closed Issue: VS2010SP1 : Difference between "Xsd2Code Generation" and "Run Custom Tool" [13966]

pcabanel — Thu, 16 May 2013 12:13:31 GMT

The Xsd2Code Generation generates a '.designer.cs' file and the 'Run Custom Tool' creates a '.Designer.cs' file.

The '.Designer.cs' file is recognized by VS2010, this file becomes a child file from the main XSD file. Which is correct.
But the '.designer.cs' is not correctly recognized by VS2010, so this file is just listed at the same level as the XSD file.

Probably this code is wrong:

Utility.cs

public static string GetOutputFilePath(string xsdFilePath, CodeDomProvider provider)
{
/* DCM REMOVED: CodeDom Provider has FileExtension
var language = GetGenerationLanguage(provider);
return GetOutputFilePath(xsdFilePath, language);
*/
return Path.ChangeExtension(xsdFilePath, ".designer." + provider.FileExtension);
}

Closed Issue: CollectionObjectType = DefinedType Fails To Generate Collection Classes [14391]

pcabanel — Thu, 16 May 2013 12:13:31 GMT

When you set the CollectionObjectType = DefinedType and set the CollectionBase setting, the actual Collection classes never get generated. Digging through the codebase I found that the CollectionTypes SortedList object is cleared ever iteration when creating the normal classes. I commented out the lines that cleared the SortedList and it started working.